Project

General

Profile

Feature #1823

trailing whitespace (PULL_REQUEST)

Added by Sonia Pozzi over 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
High
Assignee:
Sonia Pozzi
Start date:
19/10/2015
Due date:
% Done:

0%

Estimated time:

Description

Trailing whitespace not automatically fixed.
Unless forced, rejected commit.

History

#1 Updated by Erich Foster over 8 years ago

  • Assignee changed from Erich Foster to Sonia Pozzi

The following changes since commit 966b9bb02fc32e91ecfbb89c9992f20e216c103b:

Fixed and issue where .C files were ignored. (2015-09-18 09:53:19 +0200)

are available in the git repository at:

.

for you to fetch changes up to 3785687cca4d7e2cf6fd0ee36f4eec7db4c52ae5:

Made it so that all trailing whitespace is automatically fixed. Also, made it so that patches are applied to the current commit. Fixed issue where installer proceeded without specified install directory. (2015-11-18 13:31:16 +0100)

----------------------------------------------------------------
Erich L Foster (1):
Made it so that all trailing whitespace is automatically fixed. Also, made it so that patches are applied to the current commit. Fixed issue where installer proceeded without specified install directory.

.clang-format           | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 README                  |  8 +++----
 README.md               | 28 +++++++++------------------
 install.sh              | 59 ++++++++++++++++++++++++++++++---------------------------
 pre-commit-clang-format | 55 ++++++++++++++++++++++++++++++-----------------------
 pre-commit-default      | 12 +++++++++-
 6 files changed, 146 insertions(+), 73 deletions(-)
 create mode 100644 .clang-format

#2 Updated by Sonia Pozzi over 8 years ago

  • Tracker changed from Bug to Feature
  • Status changed from New to Resolved

#3 Updated by Erich Foster about 8 years ago

  • Subject changed from trailing whitespace to trailing whitespace (PULL_REQUEST)

I also fixed it so that the install script now checks if a Makefile exists and removes pre-commit-compile if it doesn't. This should have also fixed the issue with the pre-commit-clang-format not making its changes on commit.

The appropriate branch is WhtieSpace_1823.

The following changes since commit 966b9bb02fc32e91ecfbb89c9992f20e216c103b:

Fixed and issue where .C files were ignored. (2015-09-18 09:53:19 +0200)

are available in the git repository at:

.

for you to fetch changes up to bdf12b59f8a80a2463e26f7618ab5fd48e592105:

Added the automagic removal of pre-commit-compile when Makefile doesn't exist. (2016-02-15 11:16:59 +0100)

----------------------------------------------------------------
Erich L Foster (3):
Made it so that all trailing whitespace is automatically fixed. Also, made it so that patches are applied to the current commit. Fixed issue where installer proceeded without specified install directory.
Fixed the adding of files after reformat.
Added the automagic removal of pre-commit-compile when Makefile doesn't exist.

.clang-format           | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 README                  |  8 +++----
 README.md               | 28 +++++++++------------------
 install.sh              | 67 ++++++++++++++++++++++++++++++++++++++---------------------------
 pre-commit-clang-format | 54 +++++++++++++++++++++++++++++-----------------------
 pre-commit-default      | 12 +++++++++-
 6 files changed, 153 insertions(+), 73 deletions(-)
 create mode 100644 .clang-format

#4 Updated by Erich Foster almost 8 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF